Added tests of putPicturesInPage #11
Conversation
jacekkopecky
left a comment
jacekkopecky
left a comment
There was a problem hiding this comment.
mostly just polishing
package.json
Outdated
| "multer": "^1.3.0", | ||
| "mysql2": "^1.5.1" | ||
| "mysql2": "^1.5.1", | ||
| "node-fetch": "^1.7.3" |
There was a problem hiding this comment.
this doesn't need to be there
examples/tests/client-tests.js
Outdated
| @@ -0,0 +1,173 @@ | |||
| 'use strict'; | |||
|
|
|||
| fetch = () => { | |||
There was a problem hiding this comment.
please include a comment on what we're doing here and why - hiding the original fetch
examples/tests/client-tests.js
Outdated
| const elM = document.querySelector('main'); | ||
| assert.strictEqual( | ||
| elM.childElementCount, | ||
| (0+baseMainChildrenNumber), |
There was a problem hiding this comment.
we might not need the (0+ ... ) bits here
| ); | ||
| assert.ok( | ||
| document.querySelector('main .picture') == null, | ||
| ); |
There was a problem hiding this comment.
every assertion should have a message
examples/tests/client-tests.js
Outdated
|
|
||
| assert.strictEqual( | ||
| el.length, | ||
| (0), |
There was a problem hiding this comment.
don't need () - basically everywhere please
examples/tests/client-tests.js
Outdated
| let images = as[0].querySelectorAll('img'); | ||
| let deletes = section.querySelectorAll('div'); | ||
|
|
||
| assert.ok( |
| 'The `<a>` element must have its `href` attribute set to the good value.', | ||
| ); | ||
|
|
||
| assert.strictEqual( |
There was a problem hiding this comment.
we have a blank line before this block of tests, maybe add another line with a comment like
// test the image inside the a
examples/tests/client-tests.js
Outdated
| images = as[0].querySelectorAll('img'); | ||
| deletes = section.querySelectorAll('div'); | ||
|
|
||
| assert.strictEqual(listOfSections.length, 2); |
There was a problem hiding this comment.
it's better to actually repeat the messages from above because if any of these assertions fail, the developer won't be told why, what's going on
Valariael
force-pushed
the
putpicturesinpage-test
branch
2 times, most recently
from
2fd380b to
ffc96df
Compare
Valariael
force-pushed
the
putpicturesinpage-test
branch
from
ffc96df to
48ee7ad
Compare
|
Very good, thank you! We'll decide later how we'll use the PR on this repo. Please don't delete your fork. |
2 participants
For each element created or modified by the function, we test :
before and after modification.
In three cases :